Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I never want the label blob to be returned #467

Closed
jordanpadams opened this issue Apr 20, 2021 · 3 comments · Fixed by NASA-PDS/registry-api-service#35
Closed
Assignees
Labels
B12.0 p.must-have requirement the current issue is a requirement

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Apr 20, 2021

Motivation

...so that I simplify the amount of metadata/data returned by the API + the API should handle translating this via content negotiation and some other response, not through the returned metadata.

Additional Details

Acceptance Criteria

Given a deployed API with label blobs ingested
When I perform a query for a data product
Then I expect to return the associated metadata product, but NOT the blob

Engineering Details

@jordanpadams jordanpadams added requirement the current issue is a requirement needs:triage labels Apr 20, 2021
@jordanpadams jordanpadams changed the title As a developer, I want the label blob to not be returned by default As a developer, I never want the label blob to be returned Apr 22, 2021
@al-niessner
Copy link
Contributor

@jordanpadams @tloubrieu-jpl

  • Do you mean this label: ops:Label_File_Info/ops:blob
  • Do you mean this label: blob

As a design idea, you can put the blobs themselves storage (s3 or some filesystem area) with the filename md5sum_sha2sum to make them all unique. The blob metadata in the database would then be the filename which is small and remove the need for the extra filtering. It would also speed up database performance too. Downside is blobs are separated from the database requiring two areas to be backed up.

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented May 20, 2021

Hi @al-niessner , @jordanpadams , I was thinking I will work on this one. @al-niessner you can do it but this ticket is blocked by NASA-PDS/registry-api-service#27 and #456 on which I am working now.

The reason is that the xml format currently requires the blob to be in the returned elasticsearch object. I will work on the xml encoding so that it is not required anymore.

@jordanpadams
Copy link
Member Author

copy that @tloubrieu-jpl . didn't realize these were so tightly coupled.

@al-niessner we can get started on this one instead: NASA-PDS/registry-api-service#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 p.must-have requirement the current issue is a requirement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants