Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep archive misses products that specify primary products using lower case 'p' #116

Closed
jordanpadams opened this issue Jul 29, 2021 · 1 comment Β· Fixed by #117
Closed

deep archive misses products that specify primary products using lower case 'p' #116

jordanpadams opened this issue Jul 29, 2021 · 1 comment Β· Fixed by #117
Assignees
Labels
B12.0 bug Something isn't working s.low

Comments

@jordanpadams
Copy link
Member

πŸ› Describe the bug

The SIP/transfer/checksum manifest files in a Deep Archive package do not list a primary basic product designated by lowercase β€œp” in the collection inventory file. The Standards do not appear to restrict the membership value to uppercase β€œP” or β€œS” in a collection inventory file.

πŸ“œ To Reproduce

Run pds-deep-archive against a collection specifying a primary product with P instead of p

πŸ•΅οΈ Expected behavior

pds-deep-archive should be case agnostic when it comes to specifying primary/secondary products.


πŸ¦„ Related requirements

βš™οΈ Engineering Details

@nutjob4life
Copy link
Member

The code for "p-lines" currently is:

_pLineMatcher = re.compile(r'^P,\s*([^\s]+)::([^\s]+)')

So it currently matchies capital P. I think the issue title and "to reproduce" are flipped.

I'll add a test case that includes mixed case P/p to test in case (see what I did there 😏) case-insensitivity is working.

@jordanpadams jordanpadams changed the title deep archive misses products that specify primary products using upper case 'P' deep archive misses products that specify primary products using lower case 'p' Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 bug Something isn't working s.low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants