Improve CI/CD to only build off master and PRs and use datetime for PyPi deployment #27

jordanpadams · 2020-04-11T19:08:55Z

Requested update
This update includes two proposed mods:

Only build and deploy to PyPi on PRs and off merges to master (this may already be the case, but want to make sure we don't discourage people from pushing often to branches)
Per Create new pds-deep-archive program and improve performance #26 (comment), it would be great to update the Test PyPi push to use datetime to avoid these erroneous errors

Rationale
Eventually we plan to use the CI/CD from this repo as a template for other repos (and add to https://github.com/nasa-pds/pds-template-repo-python), so when we start to have repos with multiple people creating PR and branches, it would be great to avoid all these false failures to avoid confusion. Otherwise we will get numb to failures.

…empting to catalog them while also finding primaries - Also: make the pairing of lidvid → xml file unique to avoid redundnant cache entries - Use `insert or ignore` - Add a functional test that compares generated SIP with "valid" SIP - And add framework for unit+functional+integration tests - Test data accessible via setuptools `pkg_resources` - Resolve #27: An *attempt* to tag test builds for test PyPI with both a date and timestamp; this requires dropping `--tag-date` and coming up with our own date+time format—and hoping that PyPI doesn't enforce its more capricious requirements on release naming - Add running tests in the CI/CD GitHub Action - Add ability to run tests with `setup test` as well as buildout's `bin/test` - Fix extra newlines in log messages - Remove need of extra `.strip()` calls by using a smarter regexp - PEP-8 cleanups: remove needless `+` for string concatenation - Arg list documentation in function calls - Remove exec bit from test data files

…empting to catalog them while also finding primaries (#38) - Also: make the pairing of lidvid → xml file unique to avoid redundnant cache entries - Use `insert or ignore` - Add a functional test that compares generated SIP with "valid" SIP - And add framework for unit+functional+integration tests - Test data accessible via setuptools `pkg_resources` - Resolve #27: An *attempt* to tag test builds for test PyPI with both a date and timestamp; this requires dropping `--tag-date` and coming up with our own date+time format—and hoping that PyPI doesn't enforce its more capricious requirements on release naming - Add running tests in the CI/CD GitHub Action - Add ability to run tests with `setup test` as well as buildout's `bin/test` - Fix extra newlines in log messages - Remove need of extra `.strip()` calls by using a smarter regexp - PEP-8 cleanups: remove needless `+` for string concatenation - Arg list documentation in function calls - Remove exec bit from test data files

jordanpadams added enhancement New feature or request triage-needed labels Apr 11, 2020

jordanpadams assigned nutjob4life Apr 11, 2020

jordanpadams added the low label Apr 11, 2020

nutjob4life mentioned this issue Apr 20, 2020

Fix duplicate SIP and Transfer Manifest issue #38

Merged

jordanpadams closed this as completed in #38 Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve CI/CD to only build off master and PRs and use datetime for PyPi deployment #27

Improve CI/CD to only build off master and PRs and use datetime for PyPi deployment #27

jordanpadams commented Apr 11, 2020

Improve CI/CD to only build off master and PRs and use datetime for PyPi deployment #27

Improve CI/CD to only build off master and PRs and use datetime for PyPi deployment #27

Comments

jordanpadams commented Apr 11, 2020