Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIP Generator not outputting correctly for spice example bundle #39

Closed
jordanpadams opened this issue Apr 20, 2020 · 3 comments · Fixed by #42
Closed

SIP Generator not outputting correctly for spice example bundle #39

jordanpadams opened this issue Apr 20, 2020 · 3 comments · Fixed by #42
Assignees
@nutjob4life
Labels
bug Something isn't working
Milestone
PDS.15 (ends 2020...

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Apr 20, 2020 •
edited by nutjob4life
Loading

Describe the bug
When I run the latest pds-deep-archive software, there are a few issues with the output:

bin/pds-deep-archive -b https://naif.jpl.nasa.gov/pub/naif/pds/pds4/insight/ -s PDS_NAI insight_spice/bundle_insight_spice_v001.xml -d

Note: I pointed the software at v1 of the bundle (bundle_insight_spice_v001.xml ) so it should take that version and the versions it is referencing into account.

  1. The SIP only contains 1 product (should contain many more)
  2. The checksum manifest and transfer manifest both include all versions of the collections, but these should only contain the versions referenced from bundle_insight_spice_v001.xml. See AIP Generator not outputting correctly for spice example bundle #41
@jordanpadams jordanpadams added bug Something isn't working high labels Apr 20, 2020
@jordanpadams jordanpadams added this to the PDS.15 (ends 2020-04-22) milestone Apr 20, 2020
@jordanpadams
Copy link
Member Author

@nutjob4life btw, I downloaded this data and put it out on our test server /data/home/pds4/testdata/insight_spice

@nutjob4life
Copy link
Member

Note for @me: "our test server" = pds-dev-el7.jpl.nasa.gov

@nutjob4life
Copy link
Member

I'd like to split this into two issues, one effecting the AIP generation and one this SIP generation, in order to make more controlled commits & pulls to address these issues.

@nutjob4life nutjob4life mentioned this issue Apr 22, 2020
Closed
nutjob4life added a commit that referenced this issue Apr 22, 2020
@nutjob4life
Resolve #39 (and more enhancements)
eb060bf 
-   #39: SIP contains just one product for Insight Spice example
    -   We match the lidvid against all primaries found
    -   Take advantage of a new LogicalReference class for lid+lidvid manipulations
        -   This probably already exists in Java land?
    -   Look for either lid_reference or lidvid_reference in bundle XML
-   Add a way to compare, hash, and manipulate lidvids with optional vids: class LogicalReference
    -   Representation, stringification
    -   Hashing, equality, comparisons
        -   Compare version IDs smartly (i.e., 2.9 < 2.10)
    -   Matching based on partial lid or full lidvid
    -   Battery of unit tests
-   Begin support for #24 with command-line handling and flag passing
    -   But default it to True until we have time to actually put it in
        -   Include prominent warning that we're doing that
-   Remove redundant database connection use and commit
@nutjob4life nutjob4life mentioned this issue Apr 22, 2020
Merged
jordanpadams pushed a commit that referenced this issue Apr 22, 2020
@nutjob4life
Resolve #39 (and more enhancements) (#42)
dcdfd5e 
-   #39: SIP contains just one product for Insight Spice example
    -   We match the lidvid against all primaries found
    -   Take advantage of a new LogicalReference class for lid+lidvid manipulations
        -   This probably already exists in Java land?
    -   Look for either lid_reference or lidvid_reference in bundle XML
-   Add a way to compare, hash, and manipulate lidvids with optional vids: class LogicalReference
    -   Representation, stringification
    -   Hashing, equality, comparisons
        -   Compare version IDs smartly (i.e., 2.9 < 2.10)
    -   Matching based on partial lid or full lidvid
    -   Battery of unit tests
-   Begin support for #24 with command-line handling and flag passing
    -   But default it to True until we have time to actually put it in
        -   Include prominent warning that we're doing that
-   Remove redundant database connection use and commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nutjob4life nutjob4life

Labels
bug Something isn't working
Projects
None yet
Milestone
PDS.15 (ends 2020-04-22)
Development

Successfully merging a pull request may close this issue.

Update SIP Generator to ensure only primary lidvids are included in manifest NASA-PDS/deep-archive
2 participants
@nutjob4life @jordanpadams