Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to generate AIPs and SIPs using Registry #7

Closed
jordanpadams opened this issue Jan 24, 2020 · 8 comments · Fixed by #104
Closed

As a user, I want to generate AIPs and SIPs using Registry #7

jordanpadams opened this issue Jan 24, 2020 · 8 comments · Fixed by #104

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jan 24, 2020

No description provided.

@jordanpadams jordanpadams added enhancement New feature or request Epic labels Jan 24, 2020
@jordanpadams jordanpadams changed the title Implement SIP Gen online generation capabilities Implement AIP and SIP Gen online generation capabilities Apr 23, 2020
@jordanpadams jordanpadams changed the title Implement AIP and SIP Gen online generation capabilities Implement AIP and SIP generation using Registry Apr 23, 2020
@jordanpadams jordanpadams added this to the 04.Wilma.Rudolph milestone Feb 25, 2021
@tloubrieu-jpl
Copy link
Member

@nutjob4life will work on the new version of the registry and API, but the tool still need to work if the data is not available in this new registry/api since they will not be fully deployed/initialized too soon.

@tloubrieu-jpl
Copy link
Member

@nutjob4life :
The validation api end point is available on https://pds-gamma.jpl.nasa.gov/api/swagger-ui.html

The python API client is on https://github.com/NASA-PDS/pds-api-client

@tloubrieu-jpl
Copy link
Member

@nutjob4life was not able to make the python api client work. @tloubrieu-jpl need to look.

@tloubrieu-jpl
Copy link
Member

@nutjob4life is finalizing the on-going refactoring.

We'll discuss a better integration of demo client/server next Thursday.

@tloubrieu-jpl
Copy link
Member

@nutjob4life I have updated the pds-gamma api service and it now works with the api client, see https://github.com/NASA-PDS/pds-api-notebook/tree/main

Let me know if you have questions on that.

@nutjob4life
Copy link
Member

nutjob4life commented Mar 18, 2021

Confirmed! I can successfully use pds.api_client with https://pds-gamma.jpl.nasa.gov/api/. Thanks @tloubrieu-jpl

@jordanpadams jordanpadams changed the title Implement AIP and SIP generation using Registry As a user, I want to generate AIPs and SIPs using Registry Mar 26, 2021
@jordanpadams jordanpadams added requirement and removed enhancement New feature or request labels Mar 26, 2021
@nutjob4life
Copy link
Member

Just to confirm, the user inputs to generate a SIP & AIP with this will be:

  • Registry API to use (perhaps with a default like https://pds.nasa.gov/api/)
  • LIDVID of the bundle for which to make the SIP and AIP

For example:

pds-deep-archive --registry https://pds-gamma.jpl.nasa.gov/api/  urn:nasa:pds:insight_documents::2.0

Or perhaps will it a single input:

  • URL to a full LIDVID bundle within the ReST API

As in:

pds-deep-archive https://pds-gamma.jpl.nasa.gov/api/bundles/urn%3Anasa%3Apds%3Ainsight_documents%3A%3A2.0

What do you guys think @jordanpadams @tloubrieu-jpl 🤔

@jordanpadams
Copy link
Member Author

@nutjob4life i prefer option pds-deep-archive --registry https://pds-gamma.jpl.nasa.gov/api/ urn:nasa:pds:insight_documents::2.0 . This seems the simplest for the user, and they shouldn't have to care/know the REST API query for their product (also in case the API changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants