Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API POST /dois should accept DOI OSTI format in payload #148

Closed
tloubrieu-jpl opened this issue Feb 3, 2021 · 7 comments
Closed

API POST /dois should accept DOI OSTI format in payload #148

tloubrieu-jpl opened this issue Feb 3, 2021 · 7 comments
Assignees
Labels

Comments

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Feb 3, 2021

We need a way for a user to save an updated draft version of an OSTI DOI record.

We can extend the /dois POST function to accept the OSTI DOI format when action=draft

To implement that we will have some kind of identity function for the core component, the draft action should accept the OSTI format and the response will be the OSTI format. The only things done by the function will be:

  • validate the osti doi format
  • save the updated format in the transaction database.

Acceptance criteria:

  1. A valid OSTI DOI XML can be posted to the API by using the end point POS /dois.
  2. The new record is available in the GET /dois with a draft status.
@tloubrieu-jpl
Copy link
Member Author

@collinss-jpl feel free to adapt the initial design proposal to whatever you thing works best.

@tloubrieu-jpl
Copy link
Member Author

@collinss-jpl will create a class to handle any input/output (files, urls).

@tloubrieu-jpl
Copy link
Member Author

As part of this ticket the draft exception management will be corrected.

@tloubrieu-jpl
Copy link
Member Author

@collinss-jpl is making progress on that (testing phase now).

A new step would be to check how non supported format are handled for one specific action. Requirements on that needs to be detailed.

@tloubrieu-jpl
Copy link
Member Author

@collinss-jpl wil you be able to do a pull request for this ticket tomorrow ? @eddiesarevalo will need that to progress further on the UI side. Thanks.

@collinss-jpl
Copy link
Contributor

@tloubrieu-jpl Sorry for delay, will make getting the PR up top priority

@collinss-jpl
Copy link
Contributor

@tloubrieu-jpl PR is now up #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants