Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an API user, I want to always have an update date for the DOIs #184

Closed
tloubrieu-jpl opened this issue Apr 8, 2021 · 5 comments · Fixed by #190
Closed

As an API user, I want to always have an update date for the DOIs #184

tloubrieu-jpl opened this issue Apr 8, 2021 · 5 comments · Fixed by #190
Assignees
Labels
B12.0 p.could-have requirement the current issue is a requirement

Comments

@tloubrieu-jpl
Copy link
Member

Motivation

Currently when a DOI has been created but never updated, the update date is not available. In this case we want to have the update date equal to the creation date.

Additional Details

Acceptance Criteria

Given a newly created DOI (e.g. reserved)
When I perform get /dois/
Then I expect to see a valid update date, the update date should be equal to the creation date in this case.

Engineering Details

I think this should be implemented from the creation of the doi when the transaction is recorded in the database.

@tloubrieu-jpl
Copy link
Member Author

@c-suh @collinss-jpl is it still an issue, I am not seeing a problem with update dates in the latest development of Catherine ?

image

@c-suh
Copy link

c-suh commented Apr 22, 2021

@tloubrieu-jpl I don't know if this satisfies the ticket? Searching by doi or lid as a query parameter will give update_date[1][2]. Searching as a path variable will give the creation_date (no update_date) and XML record[3]

[1] http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois?doi=10.17189%2F29466
[2] http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois?lid=urn:nasa:pds:lab_shocked_feldspars::2.0
[3] http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois/urn:nasa:pds:lab_shocked_feldspars::2.0

@collinss-jpl
Copy link
Contributor

@tloubrieu-jpl This issue is still open from my perspective. I've found a number of issues with how creation/update times are being handled by the DOI service and I'm testing out fixes currently. Unfortunately I don't think I'll have the branch ready for review before we close out this sprint, but its close to being complete.

@tloubrieu-jpl
Copy link
Member Author

@c-suh , @collinss-jpl Ok, sounds good, thanks.

So maybe the request 3 should also return the update_date.

@tloubrieu-jpl
Copy link
Member Author

@collinss-jpl found a consistent way to manage the update date. He is now testing that. That should be ready for review today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 p.could-have requirement the current issue is a requirement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants