Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOI service for handling existing DOIs acceptance criteria per #175 #227

Closed
2 tasks
jordanpadams opened this issue Jul 14, 2021 · 1 comment
Closed
2 tasks
Assignees
Labels
B12.0 enhancement New feature or request

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jul 14, 2021

Engineering Details

Follow-on to #175, this acceptance criteria needs to be addressed. Per these slides, DataCite allows a user to create their own custom DOI identifier if the DOI does not exist in the system.

We want to make sure this does not happen. So we want to check our DB if that DOI exists, if not, then we should not allow an update to the metadata (it most likely means someone changed the DOI prior to submitting the update).

  • check if the code already does this check
  • implement the check if does not exist

Acceptance Criteria

Given a DOI that does not exist
When I perform an attempted update of that DOI metadata
Then I expect to receive an error message that DOI does not exist

@jordanpadams jordanpadams added this to the 11.Jesse.Owens milestone Jul 14, 2021
@jordanpadams jordanpadams changed the title Update doi service for handling existing DOIs acceptance criteria per #175 Update DOI service for handling existing DOIs acceptance criteria per #175 Jul 14, 2021
@jordanpadams
Copy link
Member Author

jordanpadams commented Jul 22, 2021

Per discussions today, this is mostly prevented by the DOI UI. A user could create their own DOI, but the system will catch if it a new DOI for the same LIDVID, so that is sufficient details.

the only way someone could misuse this is if they are using the service directly, which is not planned.

closing as wontfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants