-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I want to see the PDS3 ids as they originally are #229
Comments
The APi is actually returning the id with hyphen, see http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois?lid=*BISTATIC* (on pds-dev3) @collinss-jpl do you see how that works. We were expecting to show the original id (with /) in the UI. |
To solve this issue:
The only risk of conflict is if we have 2 identifiers like the following (HIGHLY unlikely):
we consider that will not happen. |
sqllite schema lid and vid columns are replaced by id and display-id (lid and vid are merged in the single column) |
@collinss-jpl is taking a different route to solve this ticket: the identifier will be handled in a query parameter instead of the path, as previously. That will remove the issues with He is also doing significant simplication of identifier mananagement in the code (lid+vid --> identifier). |
Motivation
...so that I can I can recognize them
Additional Details
When the id contains / they are transformed with - because of the issues with the API transmission of the strings with / in the path but we want that to be transparent to the UI user.
See
Acceptance Criteria
Given
When I perform a search request with PDS3 dois having / in them
Then I expect the results do show their id with the original /
Engineering Details
The text was updated successfully, but these errors were encountered: