Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to see the PDS3 ids as they originally are #229

Closed
tloubrieu-jpl opened this issue Jul 15, 2021 · 4 comments · Fixed by #234 or #235
Closed

As a user, I want to see the PDS3 ids as they originally are #229

tloubrieu-jpl opened this issue Jul 15, 2021 · 4 comments · Fixed by #234 or #235
Assignees
Labels
B12.0 enhancement New feature or request

Comments

@tloubrieu-jpl
Copy link
Member

Motivation

...so that I can I can recognize them

Additional Details

When the id contains / they are transformed with - because of the issues with the API transmission of the strings with / in the path but we want that to be transparent to the UI user.

See
image

  • should be / in the search result

Acceptance Criteria

Given
When I perform a search request with PDS3 dois having / in them
Then I expect the results do show their id with the original /

Engineering Details

@tloubrieu-jpl tloubrieu-jpl transferred this issue from NASA-PDS/doi-ui Jul 15, 2021
@tloubrieu-jpl
Copy link
Member Author

The APi is actually returning the id with hyphen, see http://localhost:8085/PDS_APIs/pds_doi_api/0.1/dois?lid=*BISTATIC* (on pds-dev3)

@collinss-jpl do you see how that works. We were expecting to show the original id (with /) in the UI.

@tloubrieu-jpl tloubrieu-jpl added this to the 11.Jesse.Owens milestone Jul 15, 2021
@jordanpadams jordanpadams removed their assignment Jul 22, 2021
@jordanpadams jordanpadams added the enhancement New feature or request label Jul 22, 2021
@tloubrieu-jpl
Copy link
Member Author

tloubrieu-jpl commented Jul 22, 2021

To solve this issue:

  • the API will provide a 'pds_identifier' or something else, which will be the one displayed in the UI search
  • the search criteria still need to be processed on the UI side to use the DOI database identifier where / are replaced by - .

The only risk of conflict is if we have 2 identifiers like the following (HIGHLY unlikely):

  • foo/bar-baz
  • foo-bar-baz

we consider that will not happen.

@tloubrieu-jpl
Copy link
Member Author

sqllite schema lid and vid columns are replaced by id and display-id (lid and vid are merged in the single column)

@tloubrieu-jpl
Copy link
Member Author

tloubrieu-jpl commented Jul 29, 2021

@collinss-jpl is taking a different route to solve this ticket: the identifier will be handled in a query parameter instead of the path, as previously. That will remove the issues with / management.

He is also doing significant simplication of identifier mananagement in the code (lid+vid --> identifier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants