Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user, I want to see the error/warnings messages on the same page from where they were raised #34

Closed
tloubrieu-jpl opened this issue Mar 18, 2021 · 0 comments · Fixed by #51
Closed

As a user, I want to see the error/warnings messages on the same page from where they were raised #34

tloubrieu-jpl opened this issue Mar 18, 2021 · 0 comments · Fixed by #51
Assignees
@c-suh
Labels
B12.0 p.could-have requirement the current issue is a requirement
Milestone
08.Joan.Benoit

Comments

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Mar 18, 2021 •
edited

The user will need to compare the error message with the actual data he has edited to understand better what need to be changed.

This is applicable to reserver, release/save and release/release actions.

While having the error/warning message on the form screen (reserve or release), we'll be careful to 2 things:

  • not to move the preexisting widget in the screen because of the new message (eg on release/Save, now the SAVE,RELEASE buttons are pushed down when an error message appears)
  • that the error message is clearly visible when it appear (e.g. not to have it on top of the screen while the user have scrolled down the screen to click on the button)
@tloubrieu-jpl tloubrieu-jpl added this to the 07.Evelyn.Ashford milestone Mar 18, 2021
@tloubrieu-jpl tloubrieu-jpl added B12.0 enhancement New feature or request labels Mar 18, 2021
@tloubrieu-jpl tloubrieu-jpl mentioned this issue Mar 18, 2021
Merged
@jordanpadams jordanpadams removed this from the 07.Evelyn.Ashford milestone Mar 19, 2021
@jordanpadams jordanpadams added requirement the current issue is a requirement p.could-have and removed enhancement New feature or request labels Apr 1, 2021
@tloubrieu-jpl tloubrieu-jpl added this to the 08.Joan.Benoit milestone May 13, 2021
c-suh pushed a commit that referenced this issue May 26, 2021
Rework userflow for DOI UI
f1ad980 
- Remove navigation buttons for Release and Reserve
- Add navigation buttons for Home, Search, and FAQ
- Add new page for Home
- Add new page for FAQ
- Add new page for Create DOI
- Display error/warning messages on page from which raised

Addresses #44
Addresses #34
Possibly addresses #41
Possibly addresses #42
@c-suh c-suh mentioned this issue May 27, 2021
Merged
tloubrieu-jpl pushed a commit that referenced this issue Jun 2, 2021
New Landing Page and Adjusted User Flow (#51)
8181fa6 
* Rework userflow for DOI UI

- Remove navigation buttons for Release and Reserve
- Add navigation buttons for Home, Search, and FAQ
- Add new page for Home
- Add new page for FAQ
- Add new page for Create DOI
- Display error/warning messages on page from which raised

Addresses #44
Addresses #34
Possibly addresses #41
Possibly addresses #42

* Correct button text and API calls

- Revert to appropriate actions, i.e. 'draft' and 'reserve' only
- Edit button text to say 'Submit for Review' instead of 'Release

Additional changes:
- Display DOI of newly reserved item in success message
- Add margin to bottom of page

Resolves #47
Continues #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c-suh c-suh

Labels
B12.0 p.could-have requirement the current issue is a requirement
Projects
None yet
Milestone
08.Joan.Benoit
Development

Successfully merging a pull request may close this issue.

New Landing Page and Adjusted User Flow NASA-PDS/doi-ui
3 participants
@c-suh @jordanpadams @tloubrieu-jpl