Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigation issue when using the app bar #70

Closed
tloubrieu-jpl opened this issue Jul 13, 2021 · 4 comments · Fixed by #74
Closed

navigation issue when using the app bar #70

tloubrieu-jpl opened this issue Jul 13, 2021 · 4 comments · Fixed by #74
Assignees
@eddiesarevalo
Labels
B12.0 bug Something isn't working i&t-backlog s.high

Comments

@tloubrieu-jpl
Copy link
Member

🐛 Describe the bug

The browser's back button does not work after going to a discipline node site.

📜 To Reproduce

Steps to reproduce the behavior:
See video

Screen.Recording.2021-07-13.at.9.49.14.AM.mov

🕵️ Expected behavior

The doi ui page should work or display a specific error message with redirection to a working page.

📚 Version of Software Used

branch routing_fixes

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

** 🦄 Applicable requirements**
@tloubrieu-jpl tloubrieu-jpl added bug Something isn't working needs:triage s.medium labels Jul 13, 2021
@tloubrieu-jpl tloubrieu-jpl mentioned this issue Jul 13, 2021
Merged
@eddiesarevalo
Copy link
Member

@tloubrieu-jpl This is caused by the solution #64 This is a bug. I'll install an Apache server and debug. Thanks for the video! Let me know how you recorded that in the next meeting!

@tloubrieu-jpl
Copy link
Member Author

@eddiesarevalo the video is shit-command-5 on macos.

@jordanpadams jordanpadams removed their assignment Jul 13, 2021
eddiesarevalo added a commit that referenced this issue Jul 15, 2021
@eddiesarevalo
Navigation Fix #70
64b6fdb 
-Changed BrowserRouter to HashRouter. This is due to the build procedure not allowing a basename to be determined ahead of time.
@eddiesarevalo eddiesarevalo mentioned this issue Jul 15, 2021
Merged
tloubrieu-jpl pushed a commit that referenced this issue Jul 15, 2021
@eddiesarevalo
Navigation Fix #70 (#74)
107db59 
-Changed BrowserRouter to HashRouter. This is due to the build procedure not allowing a basename to be determined ahead of time.
@tloubrieu-jpl tloubrieu-jpl reopened this Aug 5, 2021
@jordanpadams
Copy link
Member

@tloubrieu-jpl I think you meant shift in your comment above 🤣

@tloubrieu-jpl tloubrieu-jpl reopened this Aug 5, 2021
@tloubrieu-jpl
Copy link
Member Author

@tloubrieu-jpl I think you meant shift in your comment above 🤣

yes, you're right, i did not mean to be vulgar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddiesarevalo eddiesarevalo

Labels
B12.0 bug Something isn't working i&t-backlog s.high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation Fix #70 NASA-PDS/doi-ui
3 participants
@eddiesarevalo @jordanpadams @tloubrieu-jpl