New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine NPM Package And Embeddable JS Script Toolchains #17

Closed

eddiesarevalo opened this issue Aug 23, 2021 · 3 comments

Assignees

Labels

B12.1 c.doi-search enhancement skip-i&t

Member

eddiesarevalo commented Aug 23, 2021

Combine the NPM package toolchain and the embeddable JS script toolchains to create a single toolchain that performs both builds.

NPM package toolchain:
https://github.com/NASA-PDS/pds-wds-react/tree/npm-library-toolchain

Embeddable JS Script toolchain:
https://github.com/NASA-PDS/pds-wds-react/tree/js-embeddable-toolchain

eddiesarevalo self-assigned this

Member

jordanpadams commented Aug 26, 2021 •

edited by eddiesarevalo

as final step in task, remove old branches from previous iterations

Member Author

eddiesarevalo commented Sep 8, 2021

Combined toolchain added to the pds-wds-react repository:
https://github.com/NASA-PDS/pds-wds-react/tree/embed-and-npm-builder

Member Author

eddiesarevalo commented Sep 8, 2021

Deleted old branches npm-library-toolchain and js-embeddable-toolchain.

tloubrieu-jpl closed this as completed

jordanpadams transferred this issue from NASA-PDS/doi-ui

jordanpadams added B12.1 enhancement c.doi-search labels

tloubrieu-jpl added the skip-i&t label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment