-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I want to describe a relationship between an attribute in the model and the column of a table #473
Comments
from @jshughes via email:
|
We need to organize a meeting with @jordanpadams @tloubrieu-jpl to discuss how we should do that from @jshughes analysis |
This is the result of the analysis done by @jshughes on this ticket to be discussed. |
@jshughes is progressing on this ticket |
Use Case #2 – Use <DD_Attribute.Terminological_Entry> to capture alias names for an attribute defined in Ingest_LDD. The “Mission Information Commons” LDD was used as a test case. Two PDS3 aliases were found for the attribute <Mission_Information.spacecraft_clock_start> and were added as terminological entries for the attribute. The two aliases, “SPACECRAFT_CLOCK_START_COUNT” and “SCLK_START_VALUE” can be found in the Ingest_LDD code snippet below. The complete Ingest_LDD file is attached. The SKOS relation name “exactMatch” was used. No change was needed to the existing PDS4 common model. New code was added to LDDTool to write a JSON file during Ingest_LDD processing. The output was generated using the “json-simple” JSON library. The initial results are shown below. Under the key "Attribute Aliases" can be found the class name, “Mission_Information”, the attribute name, “spacecraft_clock_start”, followed by the two aliases, "SPACECRAFT_CLOCK_START_COUNT" and "SCLK_START_VALUE". Nested arrays are used to allow one or more classes, their attributes, and the aliases. There are several candidate updates to consider.
-- output-- (edited up for readability) {"infoModelVersionId":"1.18.0.0",
"datetime":"2022-06-30T12:56:42",
"Attribute Aliases":
[{"Mission_Information":
[{"spacecraft_clock_start":
["SPACECRAFT_CLOCK_START_COUNT","SCLK_START_VALUE"]
}]}],
"title":"PDS4 Terminological Entries"} -- Ingest_LDD Snippet-- <!-- Start attribute definitions for Surface_Mission class -->
<DD_Attribute>
<name>spacecraft_clock_start</name>
<version_id>1.0</version_id>
<local_identifier>spacecraft_clock_start</local_identifier>
<nillable_flag>true</nillable_flag>
<submitter_name>Susan Slavney</submitter_name>
<!-- TODO finesse definition -->
<definition>The spacecraft_clock_start is the value of the spacecraft clock at the beginning of the observation.</definition>
<!-- Begin Terminological_Entry - Attribute -->
<Terminological_Entry>
<name>SPACECRAFT_CLOCK_START_COUNT</name>
<definition>
The spacecraft clock start count element provides the value of the spacecraft clock at the beginning of a time period of interest. Note: In the PDS, sclk start counts have been represented in the following ways: Voyager - Flight Data Subsystem (FDS) clock count (floating point 7.2) Mariner 9 - Data Automation Subsystem, Mariner 10 - FDS - spacecraft clock Mars Pathfinder - spacecraft clock
</definition>
<language>English</language>
<preferred_flag>false</preferred_flag>
<skos_relation_name>exactMatch</skos_relation_name>
<External_Reference_Extended>
<reference_text>Planetary Science Data Dictionary Document, JPL D-7116, Rev. F, June 11, 2008</reference_text>
<description>Planetary Data System Version 3</description>
<name>Planetary Science Data Dictionary Document</name>
<url>https://pds.jpl.nasa.gov/datastandards/pds3/</url>
</External_Reference_Extended>
</Terminological_Entry>
<!-- End Terminological_Entry - Attribute -->
<!-- Begin Terminological_Entry - Attribute -->
<Terminological_Entry>
<name>SCLK_START_VALUE</name>
<definition>
The sclk start value element is an alias for spacecraft clock start count which is used only by AMMOS-Magellan mission operations data files.
</definition>
<language>English</language>
<preferred_flag>false</preferred_flag>
<skos_relation_name>exactMatch</skos_relation_name>
<External_Reference_Extended>
<reference_text>Planetary Science Data Dictionary Document, JPL D-7116, Rev. F, June 11, 2008</reference_text>
<description>Planetary Data System Version 3</description>
<name>Planetary Science Data Dictionary Document</name>
<url>https://pds.jpl.nasa.gov/datastandards/pds3/</url>
</External_Reference_Extended>
</Terminological_Entry>
<!-- End Terminological_Entry - Attribute --> |
Brought to DDWG today for initial review |
FIrst phase should receive OK shortly (~days). |
Latest JSON output for Term Mapping; Next step is to test with EPN-TAP mappings |
Closing this requirement right now since the initial design and implementation is complete. Test cases to follow. |
Hi @jordanpadams. Could we please get the test cases for this issue? |
In the attached zip file please find: a) the script for running LDDTool with the -T option set - runapp_TermMap_AllUseCases.bat b) the input file with the test cases - PDS4_MSN_IngestLDD_TermMap_AllUseCases.xml -starting at line 761
c) the JSON termmap output file - PDS4_PDS_1K00_TM.JSON d) the generated .xsd, .sch, and xml files. |
thanks @jshughes |
I&T Test involves, for each use case:
|
@miguelp1986 @tloubrieu-jpl @jordanpadams attached is the EPN-TAP LDD and the JSON output file. |
💪 Motivation
...so that I can use this relationship to ingest metadata within a table product into the appropriate attribute in the registry.
Specific to Product_Metadata_Supplemental (for now)
📖 Additional Details
⚖️ Acceptance Criteria
Given
When I perform
Then I expect
⚙️ Engineering Details
The text was updated successfully, but these errors were encountered: