Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

The end point /bundles/{lidvid}/products does not fully work #36

Closed
tloubrieu-jpl opened this issue Jun 3, 2021 · 3 comments
Closed
Assignees
Labels
B12.0 bug Something isn't working c.api s.medium
Milestone

Comments

@tloubrieu-jpl
Copy link
Member

🐛 Describe the bug

The following line

collectionLidVid = this.getLatestLidVidFromLid(collectionLid) + "::P1";

hard code ::P1 as part of the requested identifer of registry-refs whereas there could be multiple identifiers ::P2 ...

📜 To Reproduce

Request the end points /bndles/{lidvid}/products when there is more that 500 products per collection for at least one collection.

Some product will miss

🕵️ Expected behavior

📚 Version of Software Used

No product should miss

🩺 Test Data / Additional context

I am thinking it would be beneficial to leverage on the class https://github.com/NASA-PDS/registry-api-service/blob/master/src/main/java/gov/nasa/pds/api/engineering/elasticsearch/business/CollectionProductIterator.java and mimic the behavior of class https://github.com/NASA-PDS/registry-api-service/blob/master/src/main/java/gov/nasa/pds/api/engineering/elasticsearch/business/CollectionProductRelationships.java as BundleProductRelationships class to re-implement the method to get products of a bundle.

🏞Screenshots

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

** 🦄 Applicable requirements**

@jordanpadams
Copy link
Member

closed per #45

@gxtchen
Copy link

gxtchen commented Oct 9, 2021

@jordanpadams @tloubrieu-jpl Do we have a collection with mutiple with more than 500 products in pds-gamma?

@tloubrieu-jpl
Copy link
Member Author

@gxtchen you can try the collection with lidvid urn:nasa:pds:orex.ovirs:data_calibrated on pds-gamma.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B12.0 bug Something isn't working c.api s.medium
Projects
None yet
Development

No branches or pull requests

4 participants