Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a registry-tool/registry-user I want to ensure leading multiple forward-slashes in request paths are stripped out #208

Closed
Tracked by #30
jimmie opened this issue Dec 14, 2022 · 2 comments
Assignees
Labels
B13.1 i&t.done p.should-have requirement the current issue is a requirement

Comments

@jimmie
Copy link
Member

jimmie commented Dec 14, 2022

πŸ§‘β€πŸ”¬ User Persona(s)

Some tools insert and extra forward slash between base registry URL (pds.nasa.gov/api/search/) and the command path (/bundles/).

πŸ’ͺ Motivation

This causes a 503 from the service which does not recognize the request which arrives w/ these multiple slashes (//bundles/) but should be tolerated.

πŸ“– Additional Details

This can be handled at the Cloudfront layer

βš–οΈ Acceptance Criteria

Given a registry request URL; https://pds.nasa.gov/api/search/1.0/bundles/urn:nasa:pds:duxbury_pdart14_mariner69::2.0
When I submit this URL either in a browser or via curl
Then I expect the request to return a 200 and valid results, not a 503 response

βš™οΈ Engineering Details

Have the cloudfront function detect if multiple leading slashes exist and replace them with one.

@jimmie jimmie added needs:triage requirement the current issue is a requirement labels Dec 14, 2022
@jimmie jimmie self-assigned this Dec 14, 2022
@jimmie
Copy link
Member Author

jimmie commented Dec 14, 2022

PR 209 reviewed and merged.

@miguelp1986
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B13.1 i&t.done p.should-have requirement the current issue is a requirement
Projects
None yet
Development

No branches or pull requests

4 participants