Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundup DocsPublication step not working in maven #136

Closed
jordanpadams opened this issue Apr 10, 2024 · 5 comments Β· Fixed by NASA-PDS/pds4-information-model#757
Closed

Roundup DocsPublication step not working in maven #136

jordanpadams opened this issue Apr 10, 2024 · 5 comments Β· Fixed by NASA-PDS/pds4-information-model#757
Assignees

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Apr 10, 2024

Checked for duplicates

Yes - I've already checked

πŸ› Describe the bug

When I tagged a new release, the new docs were not pushed to gh-pages.

πŸ•΅οΈ Expected behavior

I expected the new documentation to be deployed

πŸ“œ To Reproduce

  1. Tag a new release in https://nasa-pds.github.io/pds4-information-model/
  2. Verify stable release completes successfully
  3. Verify the documentation has not been updated online
  4. Verify the gh-pages branch has not been updated

πŸ–₯ Environment Info

N/A

πŸ“š Version of Software Used

stable

🩺 Test Data / Additional context

No response

πŸ¦„ Related requirements

No response

βš™οΈ Engineering Details

Blocking NASA-PDS/pds4-information-model#754

Note: i&t.skip label applied because this is an internal automation bug. Workarounds exist but will very much delay our ability to tag new releases.

@jordanpadams
Copy link
Member Author

@nutjob4life any idea what is going on here?

@nutjob4life
Copy link
Member

Hi @jordanpadams. I only started investigating briefly on Friday. I expect to be able to devote more time to this once I can reproduce it in the sandbox.

@nutjob4life
Copy link
Member

Notes:

  • This is fixed by this pull request in pds4-information-model
  • Note that doc publication is suppressed for all Maven repositories by the PDS-EN parent pom which has <skip>true</skip> and <skipDeploy>true</skipDeploy> in the maven-site-plugin
  • Not sure this really has anything to do with roundup-action, but I'm leaving the issue here anyway πŸ˜‰

@jordanpadams
Copy link
Member Author

@nutjob4life closing this for now. I think this may be because if you have site setup both in your POM and in the parent POM, it will run both and their could be an issue? Idk. Whatever. Let's just leave this for now because I don't think we would explicitly skip it if it wasn't for a reason.

@nutjob4life
Copy link
Member

Thanks @jordanpadams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏁 Done
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants