Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project setup #1

Merged
merged 4 commits into from Aug 19, 2022
Merged

Project setup #1

merged 4 commits into from Aug 19, 2022

Conversation

NATASHA-ct
Copy link
Owner

  • Initialised React app.

  • Created re-usable components.

  • Added React Router and set two s and s for the app's navigation:

  • Created a component called Book for displaying a single book (receive a title and an author as a prop) and reuse it in a component that displays a list of books.

  • Added form for adding a book (no functionality yet).

  • Created a separate component for this form (with inputs for a title and an author) .

Copy link

@t-yanick t-yanick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NATASHA-ct,

Great job !!!

To Highlight! 👏 🟢

✔️ Good commit messages
✔️ Clean and organized code.

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NATASHA-ct NATASHA-ct merged commit ea04817 into main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants