Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary calib_index variable in radar_calibration sub-group #4

Open
marack opened this issue Jun 21, 2019 · 1 comment
Open

Unnecessary calib_index variable in radar_calibration sub-group #4

marack opened this issue Jun 21, 2019 · 1 comment

Comments

@marack
Copy link

marack commented Jun 21, 2019

The table in section 7.3.2 (page 41) lists variables for the radar_calibration subgroup. The first entry in this table is calib_index which is incorrect.

The calib_index variable is part of the per-ray metadata and is used to identify the calibration used for any given ray. It is (correctly) specified as part of the sweep group metadata under section 5.3 (page 27). It is also listed using the dimension time, which is impossible since the time dimensions are scoped to each sweep, while radar_calibration is scoped to the volume.

We should delete the calib_index row from the table in section 7.3.2.

@mike-dixon
Copy link
Collaborator

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants