Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ensemble-Stat bug for handling missing observation data for the "first" field. #1242

Closed
JohnHalleyGotway opened this issue Jan 28, 2020 · 1 comment
Assignees
Labels
priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

This is a bug that was identified via MET-Help:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=93937

When processing the "first" field in the "fcst.field" list, Ensemble-Stat initializes the output files. However, your observation file contains no data for "TMP/Z2". So there are zero pairs and it doesn't initialize the output files correctly. Your observations do contain data for "TMP/P850" so putting that first in the list causes the output files to be initialized correctly.

@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working component: application code requestor: NOAA/EMC NOAA Environmental Modeling Center priority: blocker Blocker labels Jan 28, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.0 milestone Jan 28, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Jan 28, 2020
@JohnHalleyGotway
Copy link
Collaborator Author

The fix is a one-liner.
Replace: if(i == 0) setup_txt_files();
With: setup_txt_files();
Just call setup_txt_files() for each vx task. The first thing it does is check to see if the output files have already been initialized. And if so, it simply returns.

JohnHalleyGotway added a commit that referenced this issue Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working
Projects
None yet
Development

No branches or pull requests

1 participant