Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ensemble-Stat logic for computing the forecast lead time of a time-lagged ensemble. #1244

Closed
JohnHalleyGotway opened this issue Jan 29, 2020 · 1 comment
Assignees
Labels
priority: blocker Blocker requestor: NOAA/GSL NOAA Global Systems Laboratory type: bug Fix something that is not working
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Jeff Hamilton from NOAA-GSD has been running Ensemble-Stat to generate time-lagged ensemble output. As of met-9.0_beta2, Ensemble-Stat writes to the output the timing information of the last ensemble member processed. Instead, Ensemble-Stat should write the minimum forecast lead time.

When processing a time-lagged ensemble consisting of members with 6 and 18 hour lead times, the lead time for the output should be reported as 6 hours, not 18, even if the last ensemble member was 18.

@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working component: application code priority: blocker Blocker requestor: NOAA/GSL NOAA Global Systems Laboratory labels Jan 29, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.0 milestone Jan 29, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Jan 29, 2020
@JohnHalleyGotway
Copy link
Collaborator Author

I ran a test case to define a time-lagged ensemble for 2 members: a 0-hour lead time and a 12-hour lead time, both valid at the same time. I found that the timing information reported in the output NetCDF file is the init and valid times of the FIRST ensemble member read.

For time-lagged ensembles, the valid time should remain constant, but the init time changes. We should change Ensemble-Stat to report the MAXIMUM init time encountered... and that would result in the minimum lead time.

JohnHalleyGotway added a commit that referenced this issue Jan 29, 2020
…e minimum initialization time and report that to the ensemble NetCDF output file. Remove lead_sec argument from setup_nc_file() function since it is not actually used. Update process_point_scores() and process_grid_vx() functions to use the minimum forecast lead time instead of the most common value (mode).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: blocker Blocker requestor: NOAA/GSL NOAA Global Systems Laboratory type: bug Fix something that is not working
Projects
None yet
Development

No branches or pull requests

1 participant