Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CF NetCDF input with lat/lon variable for point2grid #1345

Closed
5 of 19 tasks
hsoh-u opened this issue May 22, 2020 · 1 comment · Fixed by #1505
Closed
5 of 19 tasks

Support CF NetCDF input with lat/lon variable for point2grid #1345

hsoh-u opened this issue May 22, 2020 · 1 comment · Fixed by #1505
Assignees
Labels
reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Milestone

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented May 22, 2020

Replace italics below with details for this issue.

Describe the Enhancement

point2grid supports two input datasets: GOES16/17 and MET generated point observation data. It would be nice to support NetCDF file with lat/lon variable. There was an request via MET-HELP: https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=95225. The other case will be the tri-polar grid work for Lindasy which used python embedding. One issue is finding lat/lon variables if not CF-complaint NetCDF. It be resolved by the configuration.

Time Estimate

3 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: (Howard)
  • Select scientist(s) or no scientist required: None

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@hsoh-u hsoh-u added type: enhancement Improve something that it is currently doing component: application code labels May 22, 2020
@hsoh-u hsoh-u added this to the MET 9.1 milestone May 22, 2020
@hsoh-u hsoh-u self-assigned this May 22, 2020
@JohnHalleyGotway JohnHalleyGotway added this to To do in MET-10.0.0-beta1 (10/22/20) via automation Jun 24, 2020
@JohnHalleyGotway JohnHalleyGotway modified the milestones: MET 9.1, MET 10.0 Jun 24, 2020
@hsoh-u hsoh-u moved this from To do to In progress in MET-10.0.0-beta1 (10/22/20) Sep 8, 2020
@JohnHalleyGotway JohnHalleyGotway added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Sep 8, 2020
@TaraJensen TaraJensen added requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Sep 22, 2020
@hsoh-u hsoh-u changed the title Support NetCDF input with lat/lon variable for point2grid Support CF NetCDF input with lat/lon variable for point2grid Sep 23, 2020
@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Sep 23, 2020

Fail to read UKMet_tripolar NetCDF (CF Complaint) because "deptht_bounds" was picked as the data variable which does not have the grid information (not related with lat/lon). Need to enhance the logic on picking the data variable.

    float deptht(deptht) ;
            deptht:units = "m" ;
            deptht:long_name = "Vertical T levels" ;
            deptht:bounds = "deptht_bounds" ;
            deptht:positive = "down" ;
            deptht:axis = "Z" ;
    float deptht_bounds(deptht, axis_nbounds) ;
    float nav_lat(y, x) ;
            nav_lat:units = "degrees_north" ;
            nav_lat:long_name = "Latitude" ;
            nav_lat:standard_name = "latitude" ;
            nav_lat:nav_model = "grid_T" ;

...

    float votemper(time_counter, deptht, y, x) ;
            votemper:_FillValue = 1.e+20f ;
            votemper:coordinates = "time_instant deptht nav_lon nav_lat" ;
            votemper:online_operation = "instant" ;
            votemper:interval_write = "1 h" ;
            votemper:cell_methods = "time: point (interval: 60 s)" ;
            votemper:units = "C" ;
            votemper:missing_value = 1.e+20f ;
            votemper:interval_operation = "60 s" ;

hsoh-u pushed a commit that referenced this issue Sep 29, 2020
…me/lat/lon variables. Renamed some get_nc_att to get_nc_att_value
hsoh-u pushed a commit that referenced this issue Sep 29, 2020
hsoh-u added a commit that referenced this issue Sep 29, 2020
@hsoh-u hsoh-u moved this from In progress to Pull request review in MET-10.0.0-beta1 (10/22/20) Sep 29, 2020
hsoh-u added a commit that referenced this issue Oct 2, 2020
hsoh-u added a commit that referenced this issue Oct 2, 2020
…r the global attribute exists. Added log messages
JohnHalleyGotway pushed a commit that referenced this issue Oct 5, 2020
* #1345 Added unit test point2grid_NCCF_TO_G231

* #1345 Moved some APIs to nc_utils. Enhanced logic to find a data var

* #1345 Moved some APIs from nccf_file. Added more APIS related with time/lat/lon variables. Renamed some get_nc_att to get_nc_att_value

* #1345 Support NC Netcdf

* #1345 Removed extra comment line

* #1345 Removed dumplicated unit test oint2grid_GOES_16_AOD_TO_G212_GAUSSIAN

* #1345 Added nc_att_met_point_nccf

* #1345 Skip the grid sanity check if the environment variable is set or the global attribute exists. Added log messages

* #1345 Set the environment variable if NCCF to avoid the grid sanity checking

* #1345 USe unsetenv to deleted the environment variable.

Co-authored-by: MET Tools Test Account <met_test@dakota.rap.ucar.edu>
@JohnHalleyGotway JohnHalleyGotway moved this from Pull request review to Done in MET-10.0.0-beta1 (10/22/20) Oct 6, 2020
@JohnHalleyGotway JohnHalleyGotway linked a pull request Oct 6, 2020 that will close this issue
@hsoh-u hsoh-u closed this as completed Oct 7, 2020
@TaraJensen TaraJensen added the reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants