Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the output of point2grid to CF complaint NetCDF #1407

Open
4 of 19 tasks
hsoh-u opened this issue Jul 6, 2020 · 0 comments
Open
4 of 19 tasks

Make the output of point2grid to CF complaint NetCDF #1407

hsoh-u opened this issue Jul 6, 2020 · 0 comments
Assignees
Labels
priority: medium Medium Priority type: enhancement Improve something that it is currently doing

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Jul 6, 2020

Replace italics below with details for this issue.

Describe the Problem

point2grid does not add the global attribute "Conventions" into the output file and saves the observation time to variable attributes. There was a case the global attribute "Conventions" was added without "time" variable. The time variable should be added to be CF complaint NetCDF which MET can handle. Otherwise, the observation time will be 1970-01-01 (default from the unix time 0). One alternative is specifying file_type to NETCDF_MET to get the right time information.
With multiple -field arguments, the handling time information at CF-complaint NetCDF need to be improved: read from "time" variable and allow to override time from the variable attribute which is not CF complaint.

Expected Behavior

Provide a clear and concise description of what you expected to happen here.*

Environment

Describe your runtime environment:

  1. Machine: Linux Workstation
  2. OS: RedHat Linux
  3. MET 9.0

To Reproduce

Describe the steps to reproduce the behavior:

  1. Run point2grid
  2. Run plot_data_plane and see the mesaage

It should not show the warning
WARNING:
WARNING: NcCfFile::open() -> could not determine the valid time, using 0.
WARNING:

Relevant Deadlines

NONE.

Funding Source

NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required (Howard)
  • Select scientist(s) or no scientist required (None)

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of master_<Version>.
    Branch name: bugfix_<Issue Number>_master_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into master_<Version>.
    Pull request: bugfix <Issue Number> master_<Version> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
  • Close this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants