Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/5_read_TCDiag_ASCII_into_TCPairs #5

Open
jvigh opened this issue Apr 11, 2023 · 7 comments
Open

feature/5_read_TCDiag_ASCII_into_TCPairs #5

jvigh opened this issue Apr 11, 2023 · 7 comments
Assignees

Comments

@jvigh
Copy link
Collaborator

jvigh commented Apr 11, 2023

The goal of this issue is to get the TCDiag output from the retrospective read into TCpairs to support plotting development.

Some TCDiag outputs (generated on Casper using the python-based TCDiag code) have been staged to Seneca:
seneca:/d1/projects/TCDiag/data_output/DIAGNOSTICS/TCDIAG/2022/al092022

This repo has been cloned to Seneca at:
seneca:/d1/projects/TCDiag/TCDiag-use-cases

@bikegeek
Copy link
Collaborator

Skew-T diagram is available in the METplotpy repository:
https://github.com/dtcenter/METplotpy/tree/feature_337_tcdiag_skewt/metplotpy/plots/skew_t

@bikegeek
Copy link
Collaborator

Issue created in METplotpy to enhance the TCMPR plotter to read TCDiag lines and filter based on one column and plot another column:
dtcenter/METplotpy#342

@jvigh
Copy link
Collaborator Author

jvigh commented May 12, 2023

@KathrynNewman I've modified the standard TCPairs use case to try to read the TCDiag data, however I've run into an error:
image

It doesn't seem to like me using {date?fmt=%Y} in the file templates, however this is what the example use case uses. Is there some reason that METplus doesn't know what this date is? For instance, should it be instead using init_time?

I'll continue reading the documentation to see if I come up with anything. If you're available for a screenshare, I'm happy to set up a time this evening or Monday.

jvigh added a commit that referenced this issue May 16, 2023
…correctly. @JohnHalleyGotway, please see this issue and give your advice. Thanks.
@jvigh
Copy link
Collaborator Author

jvigh commented May 18, 2023

@georgemccabe I am getting an error in the TC-Pairs use case, but I'm not sure what it means. Something about a type error and a key model not getting passed. Do you know what this is about?

image

@georgemccabe
Copy link
Collaborator

@jvigh, it looks like there a bug in the logic that handles setting the -diag option through the wrapper. I created dtcenter/METplus#2179 to track this work.

@georgemccabe
Copy link
Collaborator

@jvigh, what do you have set for MODEL in your METplus config for this run? If it is a single variable, then you can change {model?fmt=%s} to {MODEL} in the diag template and it should substitute it properly.

If the value for MODEL is a comma-separated list of values, then do you expect the logic to find files to pass with the -diag argument that match each of the models listed? This is how the logic to find adeck and edeck files is handled.

jvigh added a commit that referenced this issue Jul 14, 2023
@jvigh
Copy link
Collaborator Author

jvigh commented Nov 1, 2023

ToDo for @jvigh: Minna needs TCMPR output (.tcst files) generated by running the TC-Pairs tool using the -diag command line option to provide diagnostic data. The data should go to Seneca or Mohawk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants