Should we include Reinit() inside of the constructor?

[shaomeng]

The following code snippet shows the constructor of TFWidget.

VAPOR/apps/vaporgui/TFWidget.cpp

Lines 39 to 52 in 348aa8f

	TFWidget::TFWidget(QWidget* parent)
	: QWidget(parent), Ui_TFWidgetGUI() {
	setupUi(this);
	_myRGB[0] = _myRGB[1] = _myRGB[2] = 1.f;
	_minCombo = new Combo(minRangeEdit, minRangeSlider);
	_maxCombo = new Combo(maxRangeEdit, maxRangeSlider);
	_rangeCombo = new RangeCombo(_minCombo, _maxCombo);
	connectWidgets();
	}

In practice, one has to always call a Reinit() function of the TFWidget immediately after its construction. Failing to do so will result in a crash. Given this behavior, does it make more sense to include a function call of Reinit() inside of the constructor?

[shaomeng]

To clarify, currently I need to do the following to construct a TFWidget:

TFWidget* tf = new TFWidget();
tf->Reinit();

If we were to adopt my feedback, I will only need the following to construct a TFWidget:

TFWidget* tf = new TFWidget();