Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of bl_mynn_tkebudget in GFS_typedefs.F90 #238

Closed
grantfirl opened this issue Mar 3, 2021 · 1 comment
Closed

Fix setting of bl_mynn_tkebudget in GFS_typedefs.F90 #238

grantfirl opened this issue Mar 3, 2021 · 1 comment

Comments

@grantfirl
Copy link
Collaborator

@egrell found a bug related to setting the bl_mynn_tkebudget control variable in GFS_typedefs.F90. In particular, the bl_mynn_tkebudget variable is not read in via namelist nor set. This should only affect diagnostic output of the MYNN PBL scheme.

To fix, simply add a couple of lines:

  1. Add the bl_mynn_tkebudget around line 3323.
  2. Add Model%bl_mynn_tkebudget = bl_mynn_tkebudget around line 3873.

This bug affects both the SCM and FV3 versions of the GFS_typedefs.F90 file. Ideally, it should be fixed in both repositories simultaneously.

@dustinswales
Copy link
Collaborator

This issue has been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants