Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression-breaking PRs should be able to supply an "override" value so tests pass #294

Open
rcabell opened this issue May 7, 2019 · 0 comments

Comments

@rcabell
Copy link
Collaborator

rcabell commented May 7, 2019

When submitting an answer-changing (or metadata-changing) PR, regression tests fail as expected, but in cases where the change is intentional, there should be a way to indicate the new, correct answer independently of the updated code.

Expected Behavior

Regression Tests should pass if code changes produce a different, but expected answer.

Current Behavior

Regression Tests fail due to changed values, even if changed values are deemed correct externally.

Possible Solution

Provide a file with expected new results, which also creates traceable documentation of the evolution of changes

Related Issues

#50 Testing: checks for data and metadata should be separated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant