Properly use kwargs for prefect's result target templating

[norlandrhagen]

Change Summary

Migrating this PR from esds-funnel.

While using funnel for caching, I ran into an unexpected error when trying to apply formatting for target names based on prefect parameters.

traceback: ```└── 16:41:35 | ERROR | Unexpected error: KeyError('gcm') Traceback (most recent call last): File "/Users/nrhagen/opt/anaconda3/envs/install/envs/cmip6-jupyter/lib/python3.9/site-packages/prefect/engine/runner.py", line 48, in inner new_state = method(self, state, *args, **kwargs) File "/Users/nrhagen/opt/anaconda3/envs/install/envs/cmip6-jupyter/lib/python3.9/site-packages/prefect/engine/task_runner.py", line 926, in get_task_run_state result = self.result.write(value, **formatting_kwargs) File "/Users/nrhagen/opt/anaconda3/envs/install/envs/cmip6-jupyter/lib/python3.9/site-packages/funnel/prefect/result.py", line 72, in write new = self.format(**{}) File "/Users/nrhagen/opt/anaconda3/envs/install/envs/cmip6-jupyter/lib/python3.9/site-packages/prefect/engine/result/base.py", line 133, in format new.location = new.location.format(**kwargs) KeyError: 'gcm' └── 16:41:35 | INFO | Task 'test_kwargs': Finished task run for task with final state: 'Failed' └── 16:41:35 | INFO | Flow run FAILED: some reference tasks failed. Flow run failed!

By editing line 72 of funnel/prefect/result.py from new = self.format(**{}) to new = self.format(**kwargs), the targeting templating seemed to succeed.

Credit goes to @tcchiao for finding a fix.

Related issue number

NCAR/esds-funnel#59

Checklist

• Unit tests for the changes exist
• Tests pass on CI
• Documentation reflects the changes where applicable

[andersy005]

@norlandrhagen, should we update the return statement in exists()

https://github.com/NCAR/xpersist/blob/e9575692935495bd3ef85a6db059b8f2e66e5e4a/xpersist/prefect/result.py#L85-L97

to

 return location.format(**kwargs) in self.cache_store 

???

I saw this being used in one of Prefect's results object: https://github.com/PrefectHQ/prefect/blob/80efb2c4f509ba6ee324c6c5c9b214a745eae6a4/src/prefect/engine/results/local_result.py#L139

[andersy005]

Thank you, @norlandrhagen and @tcchiao! I'm going to merge this shortly