Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Botulinum toxin type a shows up twice in the result set for "What treats Cerebral Palsy", one page apart with different scores for each result #167

Closed
sierra-moxon opened this issue May 1, 2023 · 6 comments
Assignees
Milestone

Comments

@sierra-moxon
Copy link
Member

https://ui.test.transltr.io/results?l=&t=&q=c572dfd1-1a94-4074-bb5a-6bd0b27cc045

page 1 result with 30 evidence
Screen Shot 2023-05-01 at 4 13 41 PM

page 2 result with 1 evidence

Screen Shot 2023-05-01 at 4 14 00 PM

Screen Shot 2023-05-01 at 4 15 52 PM

papers do not appear to overlap

@sierra-moxon
Copy link
Member Author

from TAQA:
behind the scenes, these have different identifiers (different curies) - so UI can't merge.
Chris B: could be a mistake in NN, they should be synonymous, or they could be really different and people give them the same name. That would take some more work, could be a "conflation", etc.

@sierra-moxon
Copy link
Member Author

from TAQA: this could be a NN issue.
http://identifiers.org/umls/C0006050
http://identifiers.org/unii/E211KPY694

@gaurav
Copy link

gaurav commented May 5, 2023

MESH:D019274 should connect these two cliques together (since it is connected to UMLS:C0006050 in the first clique and is itself part of the second clique), so yup, it does look like a NodeNorm issue. Let me look into what's going wrong here.

@gaurav
Copy link

gaurav commented May 8, 2023

I think the issue here is that we don't currently use MeSH identifiers when combining protein identifiers -- we only use NCIT, UMLS, UniProtKB and the protein ontology. I worry that doing that might overcombine concepts -- I'll discuss this with @cbizon and get back to you.

@cbizon
Copy link
Collaborator

cbizon commented May 8, 2023

I think that's a valid concern. We should test it out. My guess (?) is that if we're ok merging w/ NCIT & UMLS, then MESH will probably be ok as well...

@sierra-moxon
Copy link
Member Author

@gaurav - is this one closeable? :) (of course reopen if not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants