Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small molecule treats "Adult disease" #290

Closed
TranslatorIssueCreator opened this issue Jun 6, 2023 · 5 comments
Closed

Small molecule treats "Adult disease" #290

TranslatorIssueCreator opened this issue Jun 6, 2023 · 5 comments
Labels
autocomplete Red team UI - term selection identification of the specific node and context to be selected for a query

Comments

@TranslatorIssueCreator
Copy link

Type: Bug Report

URL: https://ui.test.transltr.io/results?l=Adult%20Disease&t=0&q=b4adfbe2-c0af-4d44-9791-8537865aaae3

ARS PK: b4adfbe2-c0af-4d44-9791-8537865aaae3

Steps to reproduce:

Useless, and "Adult disease" should likely be removed

Screenshots:

@dkoslicki
Copy link
Member

#288

@sierra-moxon sierra-moxon added the UI - term selection identification of the specific node and context to be selected for a query label Jun 7, 2023
@gaurav
Copy link

gaurav commented Jun 22, 2023

"Adult disease" is UMLS:C0277562, which appears to be a high-level category for diseases affecting adults. I don't know if there's a good way to filter out these high-level unnecessary categories in bulk, but we could come up with a filter list for them. The next question would be where this list should be maintained (we're tracking this question at TranslatorSRI/NameResolution#63):

  1. In Babel: UMLS:C0277562 should not be included in any cliques in Node Normalization or Name Resolution. This would prevent "adult disease" from showing up in autocomplete or in Translator results.
  2. In Name Resolution: UMLS:C0277562 could be included in NodeNorm, but should not be included in NameRes' Solr index. "Adult disease" could still show up in Translator results, but won't show up in autocomplete.
  3. In UI: calling NameRes will still return UMLS:C0277562, but the UI will filter it out when displaying autocomplete results.

Other "adult" diseases exist, but they appear to be explicitly adult forms of other diseases (e.g. "adult-onset Still disease", "Adult Alexander disease", "Recurrent Adult Hodgkin Lymphoma").

@gaurav
Copy link

gaurav commented Jun 30, 2023

Screenshot 2023-06-30 at 12 04 37 PM

These results look reasonable now. I think we can close this!

@dkoslicki
Copy link
Member

Is it someone's job to close these? Or is it up to the person who opened it?

@gaurav
Copy link

gaurav commented Jul 21, 2023

I would like the original reporter to be the person to close this after confirming that this is no longer an issue. But in this case, there is no "adult disease" in MONDO, so as long as that filter applies, this should not be an issue. So I'll go ahead and close this. We can reopen if it reappears.

@gaurav gaurav closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete Red team UI - term selection identification of the specific node and context to be selected for a query
Projects
None yet
Development

No branches or pull requests

5 participants