Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These terms are potential embarrassing as diseases #293

Closed
TranslatorIssueCreator opened this issue Jun 6, 2023 · 8 comments
Closed

These terms are potential embarrassing as diseases #293

TranslatorIssueCreator opened this issue Jun 6, 2023 · 8 comments
Labels
autocomplete Red team UI - term selection identification of the specific node and context to be selected for a query

Comments

@TranslatorIssueCreator
Copy link

Type: Bug Report

URL: https://ui.test.transltr.io/results?l=Homosexual%20Forcible%20Assault&t=0&q=cfc284ab-6e11-49da-875f-3e0fa069254e

ARS PK: cfc284ab-6e11-49da-875f-3e0fa069254e

Steps to reproduce:

Type "homosex" into search box.

Screenshots:

screenshot

@dkoslicki
Copy link
Member

#287

@gaurav
Copy link

gaurav commented Jun 6, 2023

I was hoping that those "gender identity disorder" concepts were deprecated, but nope, they appear to be valid UMLS concepts: https://uts.nlm.nih.gov/uts/umls/concept/C0270310

@sierra-moxon
Copy link
Member

what if we limit the autocomplete to only MONDO terms and their synonyms? At least for September.

@sierra-moxon sierra-moxon added the UI - term selection identification of the specific node and context to be selected for a query label Jun 7, 2023
@dnsmith124
Copy link
Collaborator

@sierra-moxon this change has been implemented, I tested it on ci and can confirm that no terms return now when searching 'homosex' or 'homosexual'

https://ui.ci.transltr.io/

@sierra-moxon
Copy link
Member

sierra-moxon commented Jun 9, 2023

Hi @dnsmith124 - that's amazing! :).

One thing I noticed is that we're not limiting the autocomplete to only HP and MONDO terms and synonyms. This means that "Fetishism" is now being returned. Maybe the "only MONDO and HP" strict limit is our best approach for September?

e.g. ci autocomplete for 'fet' (first three letters of fetal alcohol syndrome)
Screen Shot 2023-06-09 at 12 23 38 PM

vs. Ontology Lookup Service (limited to MONDO and HP)
Screen Shot 2023-06-09 at 12 26 43 PM

Maybe a standalone solr index with just those terms and synonyms for the 'treats' MVP autocomplete could be a way to go? - if SRI provided this service would it be helpful?

@gaurav
Copy link

gaurav commented Jun 22, 2023

"Fetishism" (MONDO:0001504) would not be filtered out by the MONDO/HP filter, but "transvestism" (DOID:1233), "True compulsive fetishism" (UMLS:C0270505), "fetishism partialism" (UMLS:C0270526) and "Symptomatic fetishism" (UMLS:C0270506) would be.

@gaurav
Copy link

gaurav commented Jul 21, 2023

"Fetishism" (MONDO:0001504) has now been added to the Blocklist (https://github.com/NCATSTranslator/Blocklists/blob/c899296eb31c9f5c580990d884c54a45972403d2/blocklist.yaml), but I'll keep this open until we close https://github.com/NCATSTranslator/Blocklists/issues/1, which will allow us to block all child terms of "fetishism" as well.

@gaurav
Copy link

gaurav commented Jul 28, 2023

Fetishism (e.g. fetish*) no longer returns results on https://ui.ci.transltr.io/ because of the Blocklist. Closing.

@gaurav gaurav closed this as completed Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete Red team UI - term selection identification of the specific node and context to be selected for a query
Projects
None yet
Development

No branches or pull requests

5 participants