Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all datamgmt functions to be compatible wth EML2 #184

Open
jeanetteclark opened this issue Mar 6, 2019 · 2 comments
Open

update all datamgmt functions to be compatible wth EML2 #184

jeanetteclark opened this issue Mar 6, 2019 · 2 comments
Assignees

Comments

@jeanetteclark
Copy link
Contributor

I think the main issue with this function is actually load_EML_units breaking.

this call: unitList_nS <- EML::get_unitList(x = EML::read_eml(system.file("share/EML-nS-unitDictionary.xml", package = "datamgmt"))) returns an empty list.

I believe you could just get the units from x$unit - bypassing the EML::get_unitList call entirely.

@jeanetteclark
Copy link
Contributor Author

I took a quick stab at it with 410bdee on a branch but it probably (definitely) needs to be looked at more closely

@jagoldstein jagoldstein changed the title update return_eml_units to be compatible wth EML2 update all datamgmt functions to be compatible wth EML2 May 28, 2019
@jagoldstein
Copy link

We need all the datamgmt functions updated to be compatible with the EML2 syntax before the latter package is installed, loaded, and adopted for use on the Datateam server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants