Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics displayed in the modal should be in the same order as the the metrics buttons in the dataset landing page #2100

Closed
robyngit opened this issue Feb 15, 2023 · 3 comments
Closed

Metrics displayed in the modal should be in the same order as the the metrics buttons in the dataset landing page #2100

robyngit opened this issue Feb 15, 2023 · 3 comments
Assignees
@robyngit
Labels
bug dataset landing page Enhancements and bugs for the dataset landing pages metrics Tickets for buiilding and maintaining metrics displays metrics-display
Milestone
2.23.0

Comments

@robyngit
Copy link
Member

Originally pointed out by @dvirlar2 I think - the order of the metrics on the dataset landing pages do not match the order of the metrics when you scroll through them in the modal:

The buttons (Downloads, Citations, Views)
image

The modal (Views, Citations, Downloads)
image

This has been momentarily confusing for me, since it's intuitive that they should be in the same order.
@robyngit robyngit added bug metrics Tickets for buiilding and maintaining metrics displays metrics-display dataset landing page Enhancements and bugs for the dataset landing pages labels Feb 15, 2023
@robyngit robyngit self-assigned this Feb 15, 2023
@robyngit robyngit added this to the 2.23.0 milestone Feb 15, 2023
@robyngit
Copy link
Member Author

Fixed in 23f8e18

@dvirlar2
Copy link

Thank you @robyngit!!!

@robyngit
Copy link
Member Author

Thanks for pointing it out, @dvirlar2 !! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
bug dataset landing page Enhancements and bugs for the dataset landing pages metrics Tickets for buiilding and maintaining metrics displays metrics-display
Projects
None yet
Milestone
2.23.0
Development

No branches or pull requests
2 participants
@robyngit @dvirlar2