Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to compile #113

Open
gkowalski opened this issue Sep 13, 2022 · 2 comments
Open

trying to compile #113

gkowalski opened this issue Sep 13, 2022 · 2 comments

Comments

@gkowalski
Copy link

gkowalski commented Sep 13, 2022

I've checked out master and it does not compile :

pom.xml has :

   <sourceDirectory>src</sourceDirectory>

instead of :

   <sourceDirectory>CAMP-FHIR/src</sourceDirectory>

and then I get a bunch of errors on mvn compile :

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  17.377 s
[INFO] Finished at: 2022-09-13T14:34:41-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project CAMPFHIR: Compilation failure: Compilation failure: 
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[18,29] package org.junit.jupiter.api does not exist
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[29,38] cannot find symbol
[ERROR]   symbol:   class ConditionService
[ERROR]   location: package main.java.com.campfhir.service
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[33,34] cannot find symbol
[ERROR]   symbol:   class ConditionDao
[ERROR]   location: package main.java.com.campfhir.dao
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[37,16] cannot find symbol
[ERROR]   symbol:   class ConditionService
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.ConditionConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[38,16] cannot find symbol
[ERROR]   symbol:   class ConditionDao
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.ConditionConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[18,29] package org.junit.jupiter.api does not exist
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[29,38] cannot find symbol
[ERROR]   symbol:   class PatientService
[ERROR]   location: package main.java.com.campfhir.service
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[33,34] cannot find symbol
[ERROR]   symbol:   class PatientDao
[ERROR]   location: package main.java.com.campfhir.dao
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[37,16] cannot find symbol
[ERROR]   symbol:   class PatientService
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.PatientConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[38,16] cannot find symbol
[ERROR]   symbol:   class PatientDao
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.PatientConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[44,2] cannot find symbol
[ERROR]   symbol:   class Test
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.ConditionConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[82,10] cannot find symbol
[ERROR]   symbol:   class Test
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.ConditionConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[44,2] cannot find symbol
[ERROR]   symbol:   class Test
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.PatientConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[82,10] cannot find symbol
[ERROR]   symbol:   class Test
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.PatientConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[74,21] cannot find symbol
[ERROR]   symbol:   class ConditionService
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.ConditionConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/ConditionConversionTest.java:[91,21] cannot find symbol
[ERROR]   symbol:   class ConditionService
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.ConditionConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[74,21] cannot find symbol
[ERROR]   symbol:   class PatientService
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.PatientConversionTest
[ERROR] /Users/gkowalsk/IdeaProjects/camp-fhir/CAMP-FHIR/src/main/java/com/campfhir/service/conversion/test/PatientConversionTest.java:[91,21] cannot find symbol
[ERROR]   symbol:   class PatientService
[ERROR]   location: class main.java.com.campfhir.service.conversion.test.PatientConversionTest
[ERROR] -> [Help 1]

pom does not include :

        <dependency>
            <groupId>org.junit.jupiter</groupId>
            <artifactId>junit-jupiter-api</artifactId>
            <version>5.9.0</version>
            <scope>test</scope>
        </dependency>

But adding that does not fix the issue. .. Should I be using a different Branch ?

G

@gkowalski
Copy link
Author

gkowalski commented Sep 21, 2022

ok the issue is that in commit e3eb5d2 a bunch of Service classes were dropped. and the tests dependent on line ConditionConversionTest.jave were never updated to remove these references :

image

@jameschump has gone so far as to remove these service classes from CAMFHIR.java , hope he's going to work on this test next 👍

@gkowalski
Copy link
Author

bump...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant