Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.8 #7

Closed
maximusunc opened this issue Feb 20, 2020 · 4 comments
Closed

Support python 3.8 #7

maximusunc opened this issue Feb 20, 2020 · 4 comments

Comments

@maximusunc
Copy link
Collaborator

The application currently doesn't fully support python 3.8. The newer version of python requires newer versions of numpy, sklearn, and scipy, and those in turn break pyinstaller which doesn't support 3.8 yet. (pyinstaller/pyinstaller#4311) Once pyinstaller is updated, we can revisit.

@maximusunc
Copy link
Collaborator Author

This issue (scikit-learn/scikit-learn#15899) might help as well, when attempting to build, the process would complete and we could open the application, but the server would fail to initialize because we were missing a sklearn dll (vcomp140.dll).

@maximusunc
Copy link
Collaborator Author

pyinstaller >= 4.1 now supports python 3.8. Further updates are required to make sure all dependencies are up to date and work with the new python version.

@kennethmorton
Copy link
Collaborator

We have now pumped to pyinstaller 4.3 and tested everything with python 3.8. All is well.

@kennethmorton
Copy link
Collaborator

We have now pumped to pyinstaller 4.3 and tested everything with python 3.8. All is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants