-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
having full local paths in .csv for data files still requires some location to be entered #14
Comments
@yarikoptic thanks for the issue. We can consider adding first a try that looks for the files using the paths provided (make the assumption paths are absolute), then prompt user for help in locating the files. We definitely want to preserve the feature that allows paths to be relative and not start at the root, as NDA will preserve these paths into the creation of S3 Objects and future downloads of the data. The inability for the tool to match the strings in the CSV file to file locations on the user's system (or S3 Object storage) is one of the more frequent HelpDesk tickets, and we definitely need to look at how to make this easier and/or better documented. @ericearl had similar frustrations in getting the tool to locate manifest files and the associated files therein. Any suggestions for how to make this better are welcome, I think we will try to address all current open issues in our next sprint. Depending on what that looks like we may try to tackle some improvements to bids2nda as well. |
Well, in the simplest case it is just a matter of using But related issue is that ATM that AFAIK the entirety of the full path is now used to establish the "paths into the creation of S3 Objects", so for a file with full path
|
@yarikoptic can you provide a copy of the file you started with and the arguments you provided? We are looking to make some improvements to how the script handles file paths and are having a little difficulty reproducing the exact issue. Thanks. |
eh heh, quite a bit of time has passed. We are still looking around but I am afraid it might be gone. So far got only the one with relative paths
I am surprised now that I have not posted the version (commit) of the nda-tools we used, but judging from the date, if anything fixed it should be in the e9ba5b6..66c48a0 range. But I do not spot anything which could be relevant. I guess for the next upload we will try to protocol the situation better. |
which makes little sense. I think analysis should be done in code and if paths are absolute, there should be no question asked. So I had to enter
/
directory as the location:which later on failed anyways with
The text was updated successfully, but these errors were encountered: