Update ConsoleEventListener.cs #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spent some time trying to validate the calculations being made for distance/time, but it seems impossible to account for Pokemon encounters, slow servers, transfers, evolution, etc. Therefore it makes the "Seconds until arrive at Pokestop" completely incorrect every time. The math is correct, but every time I travel to a Pokestop the timing is at least 50%-120% greater than it declares because of factors that would be way too hard to factor in for it to be worth it. I propose we (temporarily?) remove the seconds until reaching pokestop from displaying because it only adds to the obnoxious questions, "Why API Slow?" "Why it say 10s and take 20s?" Once we can accurately account for all the other factors in addition to the delay between actions, it'll be appropriate to display.
schnapster
pushed a commit
to schnapster/NecroBot
that referenced
this pull request
Dec 8, 2016
Update ConsoleEventListener.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time trying to validate the calculations being made for distance/time, but it seems impossible to account for Pokemon encounters, slow servers, transfers, evolution, etc. Therefore it makes the "Seconds until arrive at Pokestop" completely incorrect every time.
The math is correct, but every time I travel to a Pokestop the timing is at least 50%-120% greater than it declares because of factors that would be way too hard to factor in for it to be worth it. I propose we (temporarily?) remove the seconds until reaching pokestop from displaying because it only adds to the obnoxious questions, "Why API Slow?" "Why it say 10s and take 20s?"
Once we can accurately account for all the other factors in addition to the delay between actions, it'll be appropriate to display.