New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix - Clean up sniping logic #4207

Merged

BornSupercharged merged 2 commits into NecronomiconCoding:master from jjskuld:bug_fix/cleanup_sniping

Aug 10, 2016

Contributor

jjskuld commented Aug 10, 2016 •

edited

Remove redundant checks to locations visited (was checking this twice unnecessarily)
Remove double-addition and incorrect addition to locations visited (it would blacklist a location even if sniping did not occur due to full pokemon inventory for instance).
Cleanup last sniping time (should be set within the Snipe function).

By the way, this is a revert of most of the changes made in 329306b

jjskuld added 2 commits

August 9, 2016 17:48


          Bug fix - Clean up sniping logic (remove redundant checks and double-…

b29125b

…addition to locations visited, cleanup last sniping time)


          Remove unused variable

787d85a

djdookie commented Aug 10, 2016

Nice, thanks for cleaning up the snipe code!

BornSupercharged merged commit 1d5d9eb into NecronomiconCoding:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment