Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Using correct Adapter Base IP #58

Closed
splattner opened this issue Dec 8, 2017 · 3 comments
Closed

Not Using correct Adapter Base IP #58

splattner opened this issue Dec 8, 2017 · 3 comments

Comments

@splattner
Copy link

The ipHelper uses the first non internal IPv4 Address which then is used to generate the Adapter BaseURL. So there might be cases, when this does not work. Multiple NIC's, inside Docker Container.

I created a possible fix for this. See #57

@neophob
Copy link
Contributor

neophob commented Dec 8, 2017

Thanks @splattner for your report and PR. This is already possible today, see function https://neeoinc.github.io/neeo-sdk/?q=start#lib-index.js-module.exports.startserver.

you can already pass the attribute baseurl in the configuration object. looks like a doc update would make sense. What you think?

@splattner
Copy link
Author

Oh yeah, sure. Why haven't I saw this :)
It's anyway nicer to not use env Vars inside the SDK. This way you can use the evn Var to use in the configuration object.

👍 for the doc update!

@neophob
Copy link
Contributor

neophob commented Dec 9, 2017

Thanks for verifying, doc update will be part of the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants