Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdgFormatted missing variable 'headspaceTemp' #16

Closed
jhart6 opened this issue Mar 13, 2019 · 1 comment
Closed

sdgFormatted missing variable 'headspaceTemp' #16

jhart6 opened this issue Mar 13, 2019 · 1 comment

Comments

@jhart6
Copy link

jhart6 commented Mar 13, 2019

Hello! I am just getting started learning how to use the functions provided in this package to increase efficiency processing large quantities of GC data. Love this package!

I noticed that the sdgFormatted.rda, which I downloaded directly from Github, was missing the "headspaceTemp" variable column. This column appears to be a requirement for running the def.calc.sdg.conc() function. It was easy enough to append fake headspace temperatures for the sake of learning the package, but might be something helpful to include for future users.

Apologies if this is actually not a bug, and just a deficit in my own coding abilities. Thanks for writing such an amazingly well-documented and commented package!

@jhart6 jhart6 changed the title sdgFormatted missing variable headspaceTemp sdgFormatted missing variable 'headspaceTemp' Mar 13, 2019
@kcawley
Copy link
Collaborator

kcawley commented Mar 14, 2019

@jhart6 Thanks for taking the time to make an issue. I've updated the data description and file to include headspaceTemp. Let me know if you have any other trouble with the package!

@kcawley kcawley closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants