-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Extend metrics being evaluated in the plugin #17
Comments
I think showing the same percentage as the Example: @bratkartoffel any thoughts? |
Yes, that's what I would expect |
First) Had a look at the code a bit. The Setting the So removing or reworking the Second) I think the But I have to read up on btrfs and the intention of this plugin (I didn't write it and is was ported from an older Perl based script from what I can tell). Right now, I guess the intention was to compare these usage in percent against the given warning/critical thresholds:
So |
@RincewindsHat as discussed, I think we need to take a closer look at the intentions of this plugin. Feel free to chime in |
You're right, the question is, what do you expect from this plugin to do. When I take a look at the 99.49% usage for I'd like to monitor the disk and scrub status, the free disk space can be also monitored by the generic But maybe I don't understand oder misinterpret the output of the // Edit: After some reading (mainly):
(for reference here an excerpt description for the reported values from the btrfs doc)
So 99%+ usage for any of the types (metadata, system or data) is not an issue unless there is no more space unallocated. Or did I miss something? This I'd expect this plugin to check the following metrics:
|
Thanks for the additional info. I also found our old article about the plugin: https://www.netways.de/blog/2013/02/01/uberwachung-von-btrfs-filesystemen/ So the byte conversion stuff is due the I agree with your suggestion for metrics and that we might need new flags. Next step would be to agree on a CLI design. Example:
The "data ratio" and "metadata ratio" verification could be implicit or enabled with a flag, I'm not sure what's best here. @RincewindsHat any thoughts? |
Please try to fill out as much of the information below as you can. Thank you!
Which version contains the bug?
3.1.0
Describe the bug
The usage output might be wrong and or confusing. Maybe we'll just use the percentage the btrfs output shows.
Output from the plugin:
Output from
btrfs filesystem usage
Full output:
See also #13
How to recreate the bug?
No response
The text was updated successfully, but these errors were encountered: