Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some ideas for improvement #10

Closed
sklaes opened this issue Jul 27, 2023 · 10 comments
Closed

some ideas for improvement #10

sklaes opened this issue Jul 27, 2023 · 10 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@sklaes
Copy link

sklaes commented Jul 27, 2023

  • Introduce a toggle to disable the proxy e.g. --noproxy
  • Alarms: Show performance data for high, critical, medium individual e.g. | alarms=12,high=5,critical=3,medium=4;;;0
  • Alarms: allow to include / exclude alarms e.g. --exclude=medium or --include 'Certificates/'
  • capacity-usage: allow to include / exclude checks, so that you can split it into multiple icinga checks
  • Alarms: the help message could point out, that only open alarms will be checks
  • Alarms: add a timefilter, so that you can create a volatile check in icinga, to get informed for every new alarm

and by the way, the releases page on exchange.icinga.com lists v0.1.0 as latest
https://exchange.icinga.com/netways/check_vmware_nsxt/releases

@martialblog
Copy link
Member

martialblog commented Jul 27, 2023

Hi, thanks for the feedback. Most of that seems doable I think, but I have to double check.

Do you want to open a PR? Otherwise I cannot say when stuff will be implemented

@sklaes
Copy link
Author

sklaes commented Jul 28, 2023

It was just a brainstorming on how to improve the script. I haven't implemented the check in Icinga yet and I'm not sure if/which of the above features I need, so I can't say if I will implement any of them

@martialblog
Copy link
Member

No problem, feedback is always welcome.

@martialblog martialblog self-assigned this Jul 28, 2023
@martialblog martialblog added the feature New feature or request label Jul 28, 2023
@martialblog martialblog added this to the v0.2.0 milestone Jul 28, 2023
@martialblog
Copy link
Member

@sklaes Could you elaborate what you mean with the "--noproxy" option?

@sklaes
Copy link
Author

sklaes commented Aug 1, 2023

If there is an environment variable defined such as http_proxy, HTTP_PROXY, https_proxy or HTTPS_PROXY, python will use the proxy instead of a direct connection.
Having a lot of checks where some - but not all - need a proxy it is a pain in the a** to configure the no_proxy variable correctly. Something like this could make it a much easier:

if args.noproxy:
    os.environ['no_proxy'] = '*'

@martialblog
Copy link
Member

I see. Woudn't unsetting the variable on specific nodes be an option?

I'm not sure yet if this is something that should be included in the code.

@martialblog
Copy link
Member

@sklaes I'm not a user of the Plugin, can you give some details on this point?

add a timefilter, so that you can create a volatile check in icinga

@sklaes
Copy link
Author

sklaes commented Aug 15, 2023

@sklaes I'm not a user of the Plugin, can you give some details on this point?

add a timefilter, so that you can create a volatile check in icinga

You could set your check interval and the time filter to e.g. 5 min, so you will only get new alerts. The check will automatically reset to green on the next check. (You also need to mark the check as volatile in Icinga to get a notification on the first state change)
This could be useful if you have alerts that you can't solve shortly, but setting a downtime or ack is not an option, because your do not want to miss any new alerts.
However on this check I don't think it is necessary to implement, because your can acknowledge alarms individually in NSX-T and thereby exclude it from the Icinga check.

@martialblog
Copy link
Member

Thanks again. If need arises we could still do that, for now I'm not sure about implementing this.

@martialblog
Copy link
Member

We implemented a couple of the suggestions in the new release. We'll update the Icinga Exchange soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants