Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a replacement for auto-format that formats whitespace #39

Open
lazerwalker opened this issue Mar 24, 2023 · 1 comment
Open

Find a replacement for auto-format that formats whitespace #39

lazerwalker opened this issue Mar 24, 2023 · 1 comment

Comments

@lazerwalker
Copy link
Contributor

When commits hit main, we run the gdformat tool, autoformat them, and commit those changes. This kinda sucks for a number of reasons.

However, it accomplishes the thing we care about most: enforcing consistent whitespace across the project in a way that doesn't put maintenance burden on moderators to explain how to fix it to devs (since Godot whitespace settings are per-editor, not per-project).

It would be great if we could solve that whitespace problem with a more elegant solution than creating a bot commit that enforces unchangeable formatting rules that we don't necessarily agree with.

@lazerwalker lazerwalker mentioned this issue Mar 24, 2023
@paulloz
Copy link
Collaborator

paulloz commented Mar 25, 2023

For this in the current action, we should try gdformat ., see if we have the same issue as with gdformat "**/*.gd". It kinda defeats the purpose if we don't run the linter on half the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants