Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction preview #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

whaleywoo
Copy link
Contributor

I moved the instruction to the intermission so that it will show up before the microgame. I also changed the Utility functions that return random/all microgames to return microgame definitions instead (and updated session.gd and intermission.gd to use those instead) so that we could access the metadata, allowing us to get the hint verb before the minigame starts. I also moved the hint verb to the MicrogameDefinition for this reason.

@github-actions
Copy link

🎉 Please test your changes using this link! ✨👉 https://polite-glacier-037563110.2.azurestaticapps.net 👈✨

@github-actions
Copy link

🎉 Please test your changes using this link! ✨👉 https://polite-glacier-037563110.2.azurestaticapps.net 👈✨

@iznaut
Copy link
Collaborator

iznaut commented Sep 21, 2023

I think this needs a bit more work - limiting it to the intermission scene only means it stays up for less time and it's hard to keep context during the scene switch.

Pulling up a WW vid for reference, it looks like the text comes right at the end of intermission and persists through the transition into the microgame and hangs for a fair bit of time (maybe a second and a half?)

Maybe we should just load the intermission scene once, hide all the intermission content (sometime in the future we'll make it a proper transition instead) and load the microgame as a child within it.

ezgif com-gif-maker

@iznaut iznaut linked an issue Sep 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruction text should appear during Intermission
2 participants