Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary lock in EventStoreRepository #3

Open
alkampfergit opened this issue Jun 30, 2015 · 0 comments
Open

Unnecessary lock in EventStoreRepository #3

alkampfergit opened this issue Jun 30, 2015 · 0 comments
Milestone

Comments

@alkampfergit
Copy link
Contributor

In dispose method of EventStoreRepository there is a lock statement that is unnecessary.

EventStoreRepository is not thread safe, thus, the lock is not necessary.

          lock (_streams)
        {
            foreach (var stream in _streams)
            {
                stream.Value.Dispose();
            }
          ....
@alkampfergit alkampfergit added this to the v6.0.0 milestone Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant