feat(module: picker): feat create 'Picker' with dynamic #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat (module: picker): feat demo-data structure unification feat (module: picker): feat add indicatorStyle
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
- Coverage 86.54% 86.45% -0.1%
=========================================
Files 209 211 +2
Lines 6898 6955 +57
Branches 970 977 +7
=========================================
+ Hits 5970 6013 +43
- Misses 538 550 +12
- Partials 390 392 +2
Continue to review full report at Codecov.
|
3fuyu
reviewed
Nov 13, 2018
| @@ -20,7 +20,7 @@ import { takeUntil } from 'rxjs/operators'; | |||
| import { Subject } from 'rxjs'; | |||
|
|
|||
| @Component({ | |||
| selector: 'Picker, nzm-picker', | |||
| selector: 'Picker', | |||
There was a problem hiding this comment.
it is redundancy code， we do not use selector to show picker any more
| @@ -9,12 +9,14 @@ PickerView 的功能类似于 Picker ，但它是直接渲染在区域中，而 | |||
|
|
|||
There was a problem hiding this comment.
Does english md needed fixed?
3fuyu
approved these changes
Nov 14, 2018
fisherspy
pushed a commit
that referenced
this pull request
Mar 10, 2020
* feat(module: picker): feat create 'Picker' with dynamic feat (module: picker): feat demo-data structure unification feat (module: picker): feat add indicatorStyle * docs(module: picker): uptdate function description * fix(module: picker): fix init default value * feat(module:core): feat add base popup service * docs(module: picker-view): delete unuse description * fix(module:core): fix set providers of PopupService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat (module: picker): feat demo-data structure unification
feat (module: picker): feat add indicatorStyle
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information