Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: switch): feat ngModel support #145

Merged
merged 5 commits into from
Dec 11, 2018

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #145 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   86.53%   86.55%   +0.01%     
==========================================
  Files         221      221              
  Lines        6996     7005       +9     
  Branches      979      979              
==========================================
+ Hits         6054     6063       +9     
  Misses        550      550              
  Partials      392      392
Impacted Files Coverage Δ
components/switch/switch.component.ts 97.72% <100%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed144e5...3ca02cb. Read the comment docs.

@fisherspy
Copy link
Collaborator

pls sync docs as well.

@fisherspy
Copy link
Collaborator

pls check codecoverage

Copy link
Collaborator

@fisherspy fisherspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check codecoverage

@fisherspy fisherspy merged commit 6998e40 into NG-ZORRO:master Dec 11, 2018
@Guoyuanqiang Guoyuanqiang deleted the guoyq branch December 13, 2018 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants