Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: picker): picker ngModel support #165

Merged
merged 7 commits into from
Dec 17, 2018

Conversation

tirelyl
Copy link
Collaborator

@tirelyl tirelyl commented Dec 15, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #165 into master will decrease coverage by 0.13%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   86.47%   86.34%   -0.14%     
==========================================
  Files         221      221              
  Lines        7071     7081      +10     
  Branches      989      990       +1     
==========================================
- Hits         6115     6114       -1     
- Misses        561      570       +9     
- Partials      395      397       +2
Impacted Files Coverage Δ
components/picker/picker-options.provider.ts 100% <ø> (ø) ⬆️
components/picker/picker.component.ts 67.2% <100%> (-5.38%) ⬇️
components/picker/picker.directive.ts 83.95% <92.85%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d916556...f27e974. Read the comment docs.

@tirelyl tirelyl changed the title Picker ngmodel support new feat(module: picker): picker ngModel support Dec 16, 2018
@Guoyuanqiang Guoyuanqiang merged commit b4af7c7 into NG-ZORRO:master Dec 17, 2018
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
* feat(module: picker): picker ngModel support

* feat(module: picker): add  docs

* feat(module: picker): add test

* feat(module: picker): modifed api

* feat(module: picker): remove outdated api [value] and (onOk)

* feat(module: locale-provider): modified picker directive api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants