feat(module: checkbox&radio): ngModel&Onpush support #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 86.34% 86.38% +0.04%
==========================================
Files 221 221
Lines 7081 7103 +22
Branches 990 986 -4
==========================================
+ Hits 6114 6136 +22
- Misses 570 571 +1
+ Partials 397 396 -1
Continue to review full report at Codecov.
|
3fuyu
approved these changes
Dec 19, 2018
3fuyu
reviewed
Dec 19, 2018
| checked: boolean = false; | ||
| private _disabled: boolean = false; | ||
|
|
||
| private _ngModelOnChange = Function.prototype; |
There was a problem hiding this comment.
suggest write:
private _ngModelOnChange: (checked: Boolean) => void = () => {};
| private _disabled: boolean = false; | ||
|
|
||
| private _ngModelOnChange = Function.prototype; | ||
| private _ngModelOnTouched = Function.prototype; |
There was a problem hiding this comment.
suggest write:
private _ngModelOnTouched: (checked: Boolean) => void = () => {};
| checked: boolean = false; | ||
| private _disabled: boolean = false; | ||
| private _ngModelOnChange = Function.prototype; | ||
| private _ngModelOnTouched = Function.prototype; |
| @@ -3,15 +3,15 @@ import { | |||
| ViewEncapsulation, | |||
| Input, | |||
| Output, | |||
| EventEmitter, | |||
| EventEmitter, OnChanges, SimpleChanges | |||
| } from '@angular/core'; | |||
|
|
|||
| @Component({ | |||
| selector: 'SubMenu, nzm-sub-menu', | |||
| templateUrl: './sub-menu.component.html', | |||
| encapsulation: ViewEncapsulation.None, | |||
| }) | |||
|
|
||
| onChange: (value: RadioStatus) => {}; | ||
| onTouched: () => {}; | ||
|
|
| @@ -0,0 +1 @@ | |||
| <ng-content></ng-content> | |||
3fuyu
approved these changes
Dec 19, 2018
fisherspy
added a commit
that referenced
this pull request
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Checkbox & Radio Module support ngModel, so some of APIs will be modified. Please check docs for details.
Other information