Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: modal): add modal test #18

Merged
merged 1 commit into from
Oct 9, 2018
Merged

feat(module: modal): add modal test #18

merged 1 commit into from
Oct 9, 2018

Conversation

Guoyuanqiang
Copy link
Member

feat(module: modal): add modal test

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

feat(module: modal): add modal test
@fisherspy fisherspy merged commit 7c59b61 into NG-ZORRO:master Oct 9, 2018
@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #18 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   85.84%   85.93%   +0.08%     
==========================================
  Files         209      209              
  Lines        6875     6875              
  Branches      973      973              
==========================================
+ Hits         5902     5908       +6     
+ Misses        563      556       -7     
- Partials      410      411       +1
Impacted Files Coverage Δ
components/modal/modal.component.ts 81.89% <0%> (+5.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9917d...31e873b. Read the comment docs.

fisherspy pushed a commit that referenced this pull request Mar 10, 2020
feat(module: modal): add modal test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants