Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: input-item): fix input value can't be 0 or '' #185

Merged
merged 5 commits into from
Dec 25, 2018
Merged

fix(module: input-item): fix input value can't be 0 or '' #185

merged 5 commits into from
Dec 25, 2018

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 23, 2018

Codecov Report

Merging #185 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   86.25%   86.33%   +0.07%     
==========================================
  Files         222      222              
  Lines        7161     7162       +1     
  Branches     1003     1003              
==========================================
+ Hits         6177     6183       +6     
+ Misses        586      583       -3     
+ Partials      398      396       -2
Impacted Files Coverage Δ
components/input-item/input-item.component.ts 95.18% <100%> (+2.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d3478...cefd501. Read the comment docs.

@fisherspy fisherspy merged commit 59e0ea8 into NG-ZORRO:master Dec 25, 2018
@nuonuoge nuonuoge deleted the fixinputitem branch December 25, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants